Increase test coverage for ListUtils #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sigee
commented
Jul 19, 2024
sigee
commented
- isEqualList: same size, but different elements in the lists
- isEqualList: same size, same elements, but different order
- hashCodeForList: with null element
- partition.get: edge cases (Exception)
- union: multiple cases
- sum: happy path
| assertFalse(ListUtils.isEqualList(a, b)); | ||
| assertFalse(ListUtils.isEqualList(a, null)); | ||
| assertFalse(ListUtils.isEqualList(null, b)); | ||
| final List<String> list1 = new ArrayList<>( data ); |
There was a problem hiding this comment.
Please don't rename variables. I can't tell what's changed.
There was a problem hiding this comment.
I renamed them because they overlapped the String constants from lines 46, 47. And they were confusing.
private static final String a = "a";
private static final String b = "b";
final List<String> a = new ArrayList<>( data );
final List<String> b = new ArrayList<>( data );
- isEqualList: same size, but different elements in the lists - isEqualList: same size, same elements, but different order - hashCodeForList: with null element - partition.get: edge cases (Exception) - union: multiple cases - sum: happy path
|
I split the changes into two commits to make them more understandable.
|
|
@sigee |
garydgregory
added a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.